Closed Bug 981887 Opened 10 years ago Closed 10 years ago

Update button design using current BB structure and "Plan B" design

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: swilkes, Assigned: arnau)

References

(
URL
)

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken )

Attachments

(2 files, 1 obsolete file)

patch in github
46 bytes, text/x-github-pull-request
pivanov
: review+
Details | Review
buttons (device capture)
66.60 KB, image/png
pabratowski
: ui-review+
Details 
Przemek will create and attach new assets for the button design to this bug and then either flag or reassign to Arnau. This design will include button states norm, press, disabled, function, with icon.

The link to the Plan B document from Victoria is included here for reference.

For context, the FKA "common controls" work that will be included in 2.0 consists of buttons, special buttons, input fields and value selectors.
Przemek, can you include the Special Buttons and List Nav/Selection Buttons with “>" here, or would you prefer a separate bug for those?
Assignee: pabratowski → arnau
Attached image buttons after patch (obsolete) — 

        Attachment #8391218 -
        Flags: ui-review?(pabratowski)

    
    

    
  
Comment on attachment 8391218 [details]
buttons after patch

All the buttons look good but I don't believe this is the real italic version of the font. It just looks like the regular font slanted.

        Attachment #8391218 -
        Flags: ui-review?(pabratowski) → ui-review-

    
    

    
  
Przemek, I took this capture using my browser, so is showing default sans-serif. I will take a real capture from the phone on Monday.

        Attachment #8392200 -
        Flags: ui-review?(pabratowski)

    
    

    
  
Comment on attachment 8392200 [details]
buttons (device capture)

Looks good.

        Attachment #8392200 -
        Flags: ui-review?(pabratowski) → ui-review+

    
    

    
  
Comment on attachment 8391219 [details] [review]
patch in github

LGTM :)

        Attachment #8391219 -
        Flags: review?(pivanov) → review+

    
    

    
  
Just see why The Travis CI build failed you know what happened with [BB]Headers

    
    

    
  
Merged: 615b11a2dee1537773b4ff5865eb0dac7f0448b2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → 2.0+

          status-b2g-v2.0:
          --- → fixed
Target Milestone: --- → 2.0 S1 (9may)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: